SENTRY_AUTH_TOKEN passthrough to run action.#11
Merged
mdellabitta merged 1 commit intomainfrom Dec 31, 2024
Merged
Conversation
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to f3f138b in 6 seconds
More details
- Looked at
13lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. .github/workflows/ecr.yml:44
- Draft comment:
Ensure thatSENTRY_AUTH_TOKENis securely stored in GitHub Secrets and has the necessary permissions for the Sentry operations being performed. - Reason this comment was not posted:
Confidence changes required:50%
The addition of the SENTRY_AUTH_TOKEN environment variable is correctly placed under the 'Upload sourcemap to Sentry' step. However, it's important to ensure that the token is securely stored and accessed.
Workflow ID: wflow_0hmfpCwaWahRNhpg
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Add
SENTRY_AUTH_TOKENenvironment variable to GitHub Actions workflow for Sentry sourcemap upload.SENTRY_AUTH_TOKENto theUpload sourcemap to Sentrystep in.github/workflows/ecr.ymlto enable authentication when uploading sourcemaps.This description was created by
for f3f138b. It will automatically update as commits are pushed.